Add Image Width/Height in 'drawImage' #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when the image has different dimension than the wheel radius dictates. For example, I have `'outerRadius': 100,`, which means that the wheel has dimensions `200x200`, but I have an image with dimensions `600x600` (I want to keep it like this due to mobile rendering in higher resolution). So, I do this, and this works: ``` // Set the image source, once complete this will trigger the onLoad callback (above). loadedImg.src = 'wheelimage.png'; loadedImg.width = 200; loadedImg.height = 200; ``` But, without my proposed change, the image is not positioned in the canvas correctly. This PR solves this issue, we can now use any image width/height we like (different than what the wheel dimensions are).
|
This actually would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when the image has different dimension than the wheel radius dictates.
For example, I have
'outerRadius': 100,, which means that the wheel has dimensions200x200, but I have an image with dimensions600x600(I want to keep it like this due to mobile rendering in higher resolution).So, I do this, and this works:
But, without my proposed change, the image is not positioned in the canvas correctly.
This PR solves this issue, we can now use any image width/height we like (different than what the wheel dimensions are).