Fix different test failures #890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update go version to fix issues during tests where some tests requires a specific go version, above 1.17 we had setup for lab. Signed-off-by: Bruno Meneguele <[email protected]>
Make sure our CI follows the same go version stated in go.mod. Signed-off-by: Bruno Meneguele <[email protected]>
Fix styling issue reported by gofmt. Signed-off-by: Bruno Meneguele <[email protected]>
Unfortunately our testing infra relies on a real environment that get updated from time to time. This commit updates the MR number to match the test code with the actual MR live in the testing repo. Signed-off-by: Bruno Meneguele <[email protected]>
With commit 4d1dbfa ("cmd/mr_discussion.go: Switch from NotePosition to PositionOptions") the PositionOptions object was being created regardless the presence of --position in user's command, causing the REST API to fail due to the presence of a "position" parameter in the request without all required arguments. This commit creates the PositionOptions object within the --position handler, ensuring it's not passed "empty". Signed-off-by: Bruno Meneguele <[email protected]>
Due to a minimal change in tview library an additional char was added when printing the stage and jobs to the terminal. Unfortunately these tests are too sensitive to this type of changes. My suggestion is that we remove visual tests from our code, since the library has their own tests and we should not be worried on how things are really printed. Signed-off-by: Bruno Meneguele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR bring different commits to handle different test failures we're seeing on every MR.
Some failures were caused due to the nature of our test cases that run on real/live GitLab repository, but others were caused by previous code changes. At the same time, one was caused by the go version being used in our CI, requiring an update to make it work.