Requests parallel processing: #8158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- needs network addon modification!!! - network thread-sync logic modified - server-threads in breakpoints: sync, serialization and continue-button logic modified Signed-off-by: Andrey Maksimov <[email protected]>
|
See comment in the referenced zap-extensions PR. |
|
Reopening per latest comments in the other PR. |
|
Hello! Its great that 1st PR zaproxy/zap-extensions#5057 regarding the issue #8146 has been merged! Please consider proposed changes in current PR.
Proposed in this PR changes solve these problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is 2nd step to address #8146
Issue needs network addon modification!!! (network thread-sync logic modification) see 1st step PR to zap-extensions zaproxy/zap-extensions#5057
Server-threads in breakpoints: sync, serialization and continue-button logic modified.
Assumptions made are described in comments.
I tried proposed changes - they seem to be working fine. Requests are being processed in parallel, breakpoints wait for user interaction, not blocking other requests.
Probably there are some scenarios requiring further code changes? Please take a look.