Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to parse out emails for Italian users. All my users are Italian.
The regexps were all in English. I needed to support Italian regular expressions.
So I made some changes, which hopefully will allow other contributors to provide regular expressions in other languages.
Changes include:
EmailReplyParser
class to alocales.yaml
fileEmailReplyParser.read
andEmailReplyParser.parse_reply
Dependency added
pyyaml
to parse thelocales.yaml
. So added that tosetup.py
as arequires
andtests_require
option.Possible Improvements
locales.yaml
insetup
usingpackage_data
. I am new to Python, so didn't make much progress on it. But if someone can advise me what is the best approach to allow setup/install/runtime selection of configuration options - I am happy to make those changes.