Add topologySpreadConstraints configuration to pod spec. #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laiminhtrung1997
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
laiminhtrung1997
force-pushed
the
add-topologySpreadConstraints
branch
2 times, most recently
from
b948c94
to
44fcb1f
Compare
|
We need that feature too. |
FxKu
reviewed
Jun 26, 2024
| @@ -465,6 +465,11 @@ func (c *Cluster) compareStatefulSetWith(statefulSet *appsv1.StatefulSet) *compa | |||
| needsRollUpdate = true | |||
| reasons = append(reasons, "new statefulset's pod affinity does not match the current one") | |||
| } | |||
| if !reflect.DeepEqual(c.Statefulset.Spec.Template.Spec.TopologySpreadConstraints, statefulSet.Spec.Template.Spec.TopologySpreadConstraints) { | |||
| needsReplace = true | |||
| needsRollUpdate = true | |||
There was a problem hiding this comment.
does this really need to trigger a rolling update of pods executed by operator? Will not K8s take care of it then once the statefulset is replaced?
FxKu
reviewed
Jun 26, 2024
| @@ -93,6 +93,8 @@ type PostgresSpec struct { | |||
| // deprecated json tags | |||
| InitContainersOld []v1.Container `json:"init_containers,omitempty"` | |||
| PodPriorityClassNameOld string `json:"pod_priority_class_name,omitempty"` | |||
|
|
|||
| TopologySpreadConstraints []v1.TopologySpreadConstraint `json:"topologySpreadConstraints,omitempty"` | |||
There was a problem hiding this comment.
FxKu
reviewed
Jun 26, 2024
| @@ -2331,6 +2367,7 @@ func (c *Cluster) generateLogicalBackupJob() (*batchv1.CronJob, error) { | |||
| false, | |||
| "", | |||
| false, | |||
| []v1.TopologySpreadConstraint{}, | |||
There was a problem hiding this comment.
atm we reuse configured tolerations also for logical backup so I guess we can do the same with constraints
FxKu
reviewed
Jun 26, 2024
| @@ -610,6 +610,36 @@ func generatePodAntiAffinity(podAffinityTerm v1.PodAffinityTerm, preferredDuring | |||
| return podAntiAffinity | |||
| } | |||
|
|
|||
| func generateTopologySpreadConstraints(labels labels.Set, topologySpreadConstraintObjs []v1.TopologySpreadConstraint) []v1.TopologySpreadConstraint { | |||
There was a problem hiding this comment.
would like to see a unit test for this function :)
|
Can you also write an e2e test that tests that the constraints work as expected, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
I think we should configure topologySpreadConstraints to pod spec so these pods can spread zones for high availability.
Could someone review it, please? Thank you very much.
Best regards.