Fix support for string paths #77
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibaut Le Page <[email protected]>
It looks like older Pendulum versions don’t work well with a recent Poetry. Signed-off-by: Thibaut Le Page <[email protected]>
Top-level functions accept LaxPath instances, which are unions of Path and str. However, Scenario.from_path expects only a Path (not a str) and is called by _dump_as_lines (which uses LaxPath) without first converting potential strings to Path. Reported in #75. Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
🤖 zincr found 1 problem , 1 warningDetails on how to resolve are provided below ApprovalsAll proposed changes must be reviewed by project maintainers before they can be merged Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.
Large CommitsChecks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transformer is used as a library, allow to provide input HAR paths as strings as well as Path instances, as already documented in type signatures.
Closes #75.
Types of Changes
What types of changes does your code introduce? Keep the ones that apply: