Add User Agent Override to SAML Authentication #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds "samlUserAgent" key to settings dialog. If left blank, prior behavior is unchanged. If provided, the WebView Profile is adjusted with ::setHttpUserAgent() before opening the portal's SAML page.
|
Ran into a VPN that cross-checked the provided OS and OS version against the web browser user agent. (!!) This fixed it. I did have a connection hiccup where SAML succeeded at the IDP, but gpclient reported a failure. But then auto-connected immediately upon retry. I'm not sure if this patch is missing some nuance. (I'm not an experienced Qt5 developer.) |
yuezk
force-pushed
the
main
branch
15 times, most recently
from
c39bf9c
to
9dea81b
Compare
yuezk
force-pushed
the
main
branch
4 times, most recently
from
e69de98
to
187ca77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "samlUserAgent" key to settings dialog. If left blank, prior behavior is unchanged.
If provided, the WebView Profile is adjusted with ::setHttpUserAgent() before opening the portal's SAML page.