Rounded border

[yshui]

No description provided.

[yshui]

This is part of #229

[yshui]

cc @ibhagwan

[codecov]

Codecov Report

Merging #614 (b2f9f80) into next (9cb552e) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             next     #614      +/-   ##
==========================================
- Coverage   39.88%   39.79%   -0.10%     
==========================================
  Files          46       46              
  Lines        9449     9471      +22     
==========================================
  Hits         3769     3769              
- Misses       5680     5702      +22     

Impacted Files	Coverage Δ
src/opengl.c	0.00% <0.00%> (ø)
src/opengl.h	60.46% <ø> (ø)
src/render.c	4.14% <0.00%> (ø)
src/win.c	68.01% <0.00%> (-0.13%)	⬇️
src/win.h	78.12% <ø> (ø)

[tryone144]

This looks okay to me.
Unfortunately, I can't really test it locally at the moment as I only have i3's fake borders at hand and my test-system doesn't cooperate.

[tryone144]

Just for consistency, the function is now called glx_round_corners_dst() and the first value for border_col is written with a trailing dot.

[yshui]

Ah, thanks for pointing it out!

[yshui]

@tryone144 I think the approach should work with "fake" borders

Edit: ah, no. Because border width detection wouldn't work... Related: i3/i3#4292

[owl4ce]

Hi, is it possible to turn off borders on this window?

This only happens when turning on rounded corners with the glx backend. I use OpenboxWM.

[ibhagwan]

This only happens when turning on rounded corners with the glx backend. I use OpenboxWM.

That’s because rounded borders are only supported on glx.

You can turn it off globally with the round-borders = 0; option or individually with the round-borders-exclude option, use xprop for the windows you’d like it turned off and refer to picom.sample.conf if you’re unclear how to use the option.

[owl4ce]

This only happens when turning on rounded corners with the glx backend. I use OpenboxWM.

That’s because rounded borders are only supported on glx.

You can turn it off globally with the round-borders = 0; option or individually with the round-borders-exclude option, use xprop for the windows you’d like it turned off and refer to picom.sample.conf if you’re unclear how to use the option.

Using all border options doesn't work to disable. It only happens in Openbox's own drawn window and can't use xprop because of conflict when grabbing the cursor.

EDIT: That includes this rule "! name~=''"

[ibhagwan]

This only happens when turning on rounded corners with the glx backend. I use OpenboxWM.

That’s because rounded borders are only supported on glx.
You can turn it off globally with the round-borders = 0; option or individually with the round-borders-exclude option, use xprop for the windows you’d like it turned off and refer to picom.sample.conf if you’re unclear how to use the option.

Using all border options doesn't work to disable. It only happens in Openbox's own drawn window and can't use xprop because of conflict when grabbing the cursor.

EDIT: That includes this rule "! name~=''"

I took a quick glance at the code, I don’t think the border exclude options were implemented here yet, if you’d like to give these options a try use my fork instead.

[owl4ce]

Solved for temporary, back using picom from this commit.
9cb552e