Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback already called #28

Merged
merged 4 commits into from
May 21, 2024
Merged

Fix callback already called #28

merged 4 commits into from
May 21, 2024

Commits on May 18, 2024

  1. Fix misconfiguration error messages 

    If you call multiple callbacks from the loader, the error:
Error: callback(): The callback was already called.
Will appear.  Return early for pre-condition callbacks instead 
so appropriate error appears in console.
    @jvoccia
    jvoccia committed May 18, 2024
    Configuration menu
    Copy the full SHA
    b5702e2 View commit details
    Browse the repository at this point in the history

  2. Reorder work so if an SVG is invalid 

    It is not processed by the Plugin.
    @jvoccia
    jvoccia committed May 18, 2024
    Configuration menu
    Copy the full SHA
    556fcc4 View commit details
    Browse the repository at this point in the history

  3. Add Tests

    @jvoccia
    jvoccia committed May 18, 2024
    Configuration menu
    Copy the full SHA
    bf2ec56 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Fix lint

    @yoriiis
    yoriiis committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6f80fb9 View commit details
    Browse the repository at this point in the history