Improving perfomance for JSON Lines format #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves performance when loading JSON Lines format.
Loading JSON Lines cause significant slowdown and stop accepting keys, even if the length is moderate.
This situation can be reproduced like follows.
For visualization and suggestions, the entire long list is not necessary, but a partial list of some length is enough.
Therefore I have created simple patch.
--limit-length
option to be able to specify the lengthI often deal with JSON-Lines files that have tens of thousands of lines, so I hope jnv can handle them comfortably.