Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hex for ip6 literal addr, fix #1800 #1830

Merged
merged 3 commits into from
May 26, 2024

Conversation

seanpquinn
Copy link
Contributor

Built and ran all tests

[----------] Global test environment tear-down
[==========] 239 tests from 65 test suites ran. (128182 ms total)
[  PASSED  ] 239 tests.

  YOU HAVE 2 DISABLED TESTS


C:\Users\Sean Quinn\Desktop\github\cpp-httplib\test\x64\Debug\test.exe (process 4004) exited with code 0.
Press any key to close this window . . .

@yhirose
Copy link
Owner

yhirose commented May 2, 2024

@seanpquinn could you please add some unit tests for this change?

@seanpquinn
Copy link
Contributor Author

Original code

Running main() from C:\Users\Sean Quinn\Desktop\github\cpp-httplib\test\gtest\gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from UniversalClientImplTest
[ RUN      ] UniversalClientImplTest.Ipv6LiteralAddress
C:\Users\Sean Quinn\Desktop\github\cpp-httplib\test\test.cc(1742): error: Expected equality of these values:
  cli.port()
    Which is: 80
  port
    Which is: 4321
[  FAILED  ] UniversalClientImplTest.Ipv6LiteralAddress (1 ms)
[----------] 1 test from UniversalClientImplTest (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] UniversalClientImplTest.Ipv6LiteralAddress

 1 FAILED TEST

C:\Users\Sean Quinn\Desktop\github\cpp-httplib\test\x64\Debug\test.exe (process 22920) exited with code 1.
Press any key to close this window . . .

with change

Running main() from C:\Users\Sean Quinn\Desktop\github\cpp-httplib\test\gtest\gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from UniversalClientImplTest
[ RUN      ] UniversalClientImplTest.Ipv6LiteralAddress
[       OK ] UniversalClientImplTest.Ipv6LiteralAddress (0 ms)
[----------] 1 test from UniversalClientImplTest (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2 ms total)
[  PASSED  ] 1 test.

C:\Users\Sean Quinn\Desktop\github\cpp-httplib\test\x64\Debug\test.exe (process 26864) exited with code 0.
Press any key to close this window . . .

@yhirose yhirose merged commit 98cc1ec into yhirose:master May 26, 2024
2 of 4 checks passed
@yhirose
Copy link
Owner

yhirose commented May 26, 2024

@seanpquinn thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants