Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for C++ 20 compatibility #2774

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update for C++ 20 compatibility #2774

wants to merge 2 commits into from

Conversation

laramiel
Copy link
Contributor

Description

C++ 20 deprecates some std::allocator members. This PR updates xtensor allocators to work with C++20.

https://en.cppreference.com/w/cpp/memory/allocator

@laramiel
Copy link
Contributor Author

I think that the build checks need to be re-run.

@tdegeus
Copy link
Member

tdegeus commented Mar 19, 2024

Thanks! Looks good to me.

@tdegeus tdegeus added the C++20 label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdegeus tdegeus tdegeus approved these changes

@JohanMabille JohanMabille Awaiting requested review from JohanMabille

Assignees
No one assigned
Labels
C++20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laramiel @tdegeus