Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1829 (comment)
@Niek tested with https://test.mosquitto.org/ - test.mosquitto.org:8883, https://test.mosquitto.org/ssl/mosquitto.org.crt as custom .pem root
I also noticed that we may need to specify it clearer that it is not a client certificate, but root cert of the server.
_mqtt_client_ca
->_mqtt_client_server_ca
?And SecureClientHelpers do the rest. Since we want to have up-to-date config, allow module to define "config" struct with all of the settings as getters. "...scCheck" logic is separated in to internal "checks" struct, running all of the relevant actions based on "config" results.
AsyncMqttClient is still special case, because it handles fingerprinting all by itself. Difference from
dev
is that fingerprint only added on module setup, not with every configuration reload.Also notice a little optimization with onconnect verification for axtls. No need to overcomplicate things if it will be removed anyway.