Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: update array slice order option #494

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hank0626
Copy link
Contributor

@Hank0626 Hank0626 commented Jun 5, 2023

What do these changes do?

  • Deal with the big time cost of to_chunk_op when processing the order conversion.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Jun 5, 2023
@XprobeBot XprobeBot added this to the v0.3.2 milestone Jun 5, 2023
@Hank0626 Hank0626 marked this pull request as draft June 5, 2023 05:49
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #494 (7a804a1) into main (d2e1622) will increase coverage by 11.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #494       +/-   ##
===========================================
+ Coverage   82.32%   93.63%   +11.30%     
===========================================
  Files         998      998               
  Lines       77520    77520               
  Branches    16107    16107               
===========================================
+ Hits        63820    72582     +8762     
+ Misses      11536     3303     -8233     
+ Partials     2164     1635      -529     
Flag Coverage Δ
unittests 93.53% <ø> (+11.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/_mars/tensor/datasource/array.py 89.68% <ø> (ø)

... and 165 files with indirect coverage changes

@XprobeBot XprobeBot modified the milestones: v0.3.2, v0.4.1 Jul 1, 2023
@XprobeBot XprobeBot modified the milestones: v0.4.1, v0.4.3 Jul 11, 2023
@XprobeBot XprobeBot modified the milestones: v0.4.3, v0.4.4, v0.4.5 Jul 20, 2023
@XprobeBot XprobeBot modified the milestones: v0.5.0, v0.5.1 Jul 28, 2023
@XprobeBot XprobeBot modified the milestones: v0.5.1, v0.5.2 Aug 14, 2023
@XprobeBot XprobeBot modified the milestones: v0.5.2, Temp, v0.6.0, v0.6.1 Sep 8, 2023
@XprobeBot XprobeBot modified the milestones: v0.6.1, v0.6.2, v0.6.3 Sep 15, 2023
@XprobeBot XprobeBot modified the milestones: v0.6.3, v0.7.0 Sep 25, 2023
@XprobeBot XprobeBot modified the milestones: v0.7.0, v0.7.1 Oct 23, 2023
@XprobeBot XprobeBot removed this from the v0.7.1 milestone Nov 21, 2023
@XprobeBot XprobeBot added this to the v0.7.2 milestone Nov 21, 2023
@XprobeBot XprobeBot modified the milestones: v0.7.2, v0.7.3 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants