Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functions to allow hubot to create rooms and invite users to rooms #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pseudomorph
Copy link

Using this to make dynamic room creation/interaction for our workflow.

@markstory
Copy link
Contributor

It would be good to have a test case for this, so it doesn't get broken in any future refactoring/work.

@krutaw
Copy link

krutaw commented Jul 11, 2016

This would be a darn nifty feature to have. Any chance the conflicts can be corrected and this feature documented?

@markstory
Copy link
Contributor

@krutaw I probably won't be able to find the time to do that, but if you have the time I'm happy to merge this kind of change.

@krutaw
Copy link

krutaw commented Jul 12, 2016

@markstory It's not a lack of time on my part, but a lack of understanding on how to write the test case you mentioned earlier in the thread as well as how to identify the conflicts that currently exist.

@markstory
Copy link
Contributor

Generally the tests would be asserting that the XML being send to the jabber server is correctly formed. You can likely use something like the ping/pong test as an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants