Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reportlab Compatibility: Adapt to New ShowBoundaryValue Import #754

Merged
merged 4 commits into from
Jun 8, 2024
Merged

reportlab Compatibility: Adapt to New ShowBoundaryValue Import #754

merged 4 commits into from
Jun 8, 2024

Conversation

stefan6419846
Copy link
Contributor

@stefan6419846 stefan6419846 commented Feb 10, 2024 •
edited

Short description

Fix compatibility with reportlab>=4.0.9.1.

Proposed changes

  • Use new import if possible.
  • Fallback to old import if required.

Resolved issues

Fixes: #751 (cleanly)

jorenham
jorenham reviewed Feb 14, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@Guthers
Copy link

Guthers commented Apr 21, 2024

Are there plans to deploy this any time soon? Thanks for the great lib!

@stefan6419846 stefan6419846 mentioned this pull request Apr 30, 2024
Open
timobrembeck
timobrembeck approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay and thank you so much for figuring out the problem! 🙏

@timobrembeck timobrembeck merged commit 4c010d6 into xhtml2pdf:master Jun 8, 2024
5 checks passed
@stefan6419846 stefan6419846 deleted the showboundaryvalue branch June 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutervh woutervh woutervh left review comments

@jorenham jorenham jorenham left review comments

@timobrembeck timobrembeck timobrembeck approved these changes

@luisza luisza Awaiting requested review from luisza luisza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

broken reportlab import
5 participants
@stefan6419846 @Guthers @woutervh @jorenham @timobrembeck