BertProcessing add_prefix_space, trim_offsets #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use config properties to trim space from tokens
shavit
force-pushed
the
add-prefix-space-bert
branch
from
2a2d974
to
efe7d90
Compare
|
Thanks for working on this! Do you maybe know of any model(s) and input for which these changes correct the current behaviour? The current set of supported models and unit tests do not have any issues with this. |
|
No, I just saw that this is missing from RobertaProcessing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use config properties to trim space from tokens
https://github.com/xenova/transformers.js/blob/main/src/tokenizers.js#L1626