Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --version option in the same manner as --help. #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcoltau
Copy link

@pcoltau pcoltau commented Apr 9, 2019

I've added a --version option in the same manner as the --help option.

The version can be provided in the ArgParser constructor if needed. If it is not provided, no --version option will be added. This makes the change fully compatible with older versions of the ArgParser.

I've also added a -v option for the version, but I'm unsure if this is wanted. Let me know, and I can remove it.

@codecov-io
Copy link

Codecov Report

Merging #70 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage      84.9%   85.21%   +0.31%     
- Complexity      138      139       +1     
============================================
  Files            11       11              
  Lines           424      433       +9     
  Branches         84       85       +1     
============================================
+ Hits            360      369       +9     
  Misses           27       27              
  Partials         37       37
Impacted Files Coverage Δ Complexity Δ
...main/kotlin/com/xenomachina/argparser/ArgParser.kt 91.12% <100%> (+0.25%) 55 <0> (+1) ⬆️
...ain/kotlin/com/xenomachina/argparser/Exceptions.kt 95.65% <100%> (+0.65%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263784f...9a49bbe. Read the comment docs.

@pcoltau
Copy link
Author

pcoltau commented Jun 11, 2019

Any chance of getting this merged?

@Malinskiy
Copy link

+1 for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants