Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Recipient instead of Address (Signal v4.48.0 breaking change) #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maximeborges
Copy link

Starting from v4.48.0 of Signal, the database is now using the RecipientID instead of the Address field for the SMS and MMS, while the previous information of Address now stocked in the Phone field of the Recipient table.

https://github.com/signalapp/Signal-Android/blob/v4.48.0/src/org/thoughtcrime/securesms/database/SmsDatabase.java#L77

@orelus
Copy link

orelus commented Oct 28, 2019

Thanks.

But i still have the ADDRESS field in CSV header and no RecipientID.
If I try to generate XML, the file is empty.

@maximeborges
Copy link
Author

maximeborges commented Oct 28, 2019

I was mainly working on the XML export to be able to reimport them using SMS Backup & Restore.
Last commit should bring back the `ADDRESS{ field with the phone number.

Concerning your problems, how have you retrieved my modifications ?
I think the only way is to do as following, not to beak up anything and use the correct packages: https://stackoverflow.com/a/29161911

It's the first project I worked on in Go, so I might be wrong, but this is working for me.

Tl;Dr: go get the xeals version in $GOPATH, use the remote from my repo and build.

@oldmanwl
Copy link

oldmanwl commented Nov 1, 2019

@maximeborges Your fork fixed one problem I'd encountered with the @xeals master, where none of the imported conversations were tagged with actual phone numbers... but it didn't fix the other, where I would lose MMS threads so that anything I'd received from a particular person in different MMS threads would get combined in a single thread. Not sure if these two issues are related, so my apologies if the second issue doesn't belong here.

@ajayyy
Copy link

ajayyy commented Jan 13, 2020

This PR is creating an empty result for me (count of zero)

Edit: Nevermind, I fixed that. It was due to not pulling in the main repo first.

However, now the address fields are blank.

abstern added a commit to abstern/signal-back that referenced this pull request Jul 1, 2021
Merge fix xeals#64 from maximeborges/signal-back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants