Do not erase but update compilation database. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Lint/Eval has the wrong namespace - should be Security .rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/ClosingParenthesisIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout .rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead. (obsolete configuration found in .rubocop.yml, please update it)
When using the -r json-compilation-database option, if a database already exists, it is completely rewritten. This has the side effect that when using incremental compilation, the compilation commands for the files that are not recompiled are lost. This has the effect that tools using the database like clang-tidy won't find the compilation commands for file that were not recompiled. This commit changes the database generation code so that it updates the database with the detected commands instead of rewriting it.
canatella
force-pushed
the
update-compilatio-database
branch
from
117f9c2
to
50e1d61
Compare
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Lint/Eval has the wrong namespace - should be Security .rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/ClosingParenthesisIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout .rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead. (obsolete configuration found in .rubocop.yml, please update it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the -r json-compilation-database option, if a database already
exists, it is completely rewritten. This has the side effect that when using
incremental compilation, the compilation commands for the files that are not
recompiled are lost. This has the effect that tools using the database like
clang-tidy won't find the compilation commands for file that were not
recompiled.
This commit changes the database generation code so that it updates the database
with the detected commands instead of rewriting it.