Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat check dependencies output as warnings #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbektchiev
Copy link

@mbektchiev mbektchiev commented Mar 24, 2017

Check dependencies has no output if no problems are found. Treat all unrecognized lines as warnings.

This way they won't be totally missing from the output generated by xcpretty. I'm not sure whether all of them are errors and would abort the build, that's why this is safer than treating them as errors. We can still add patterns for known errors, but it seems that they could come in various formats and it's not feasible to list them all.

@mbektchiev mbektchiev changed the title Check dependencies has no output if no problems are found Treat check dependencies output as warnings Mar 27, 2017
@mbektchiev mbektchiev force-pushed the check-dependencies-warnings branch 2 times, most recently from 39143e7 to 992e264 Compare March 28, 2017 12:24
Treat all unrecognized lines as warnings
@mbektchiev
Copy link
Author

@supermarin, Can you review this one as well? And publishing a new version would be very nice to have, as there are some nice improvements since 0.2.5.

@supermarin
Copy link
Contributor

@mbektchiev reviewed, although I'm not sure this is the right solution.

Check Dependencies is just a regular step (it's more like a section) that contains a few sub commands.
It should not be treated as a warning IMO.

Let me know your thoughts

@supermarin
Copy link
Contributor

re: publishing a new version, will get on it today

@supermarin
Copy link
Contributor

@mbektchiev published 0.2.6

@mbektchiev
Copy link
Author

Yes, it indeed is a regular step and theoretically it could have output which shouldn't be treated as warnings. But unfortunately there are a lot of variations of messages that this step can generate and I haven't seen ones that are not in fact warnings or errors.

On the other hand, this step never prints anything if all checks are OK, that's why I think that this is still the better approach to the alternative of hiding the whole output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants