Add the JUnit time attribute on a failed tests.
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Sonar JUnit parser fails if the time attribute is not present on failed tests. This patch adds the time attribute for these tests with a fixed duration of "0". Adding the real test duration was considered however it cannot be done easily with the current xcpretty implementation: xcpretty parses Xcode output line by line whereas a failed test outputs at least 2 lines of log: one that shows the failed test and the cause, another that displays the duration (quite the same line as a passing test). A considered approach would be to keep a context and output a transformed log line only if the context is full (in the case of failed tests, only if the cause and the duration have been parsed).
|
Any news on this? I'm having the same issue and made the exact same fix in my fork. |
|
@Palleas this will be addressed after releasing 0.3. |
|
Great news! |
|
Hello, |
|
you can use / test it with |
|
Alright, thanks @supermarin. I'll have a look. |
|
Um. This blocking people using xcpretty with Sonar and is a trivial change. Why can we not get a |
|
@orj sorry for the late feedback on this. I'm pretty sure time value is present on the test run output. I think we should parse it and add properly vs just adding a zero. Mind looking into that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sonar JUnit parser fails if the
timeattribute is not present onfailed tests. This patch adds this attribute for these tests with a
fixed duration of "0".
Adding the real test duration was considered however it cannot be
done easily with the current xcpretty implementation: xcpretty parses
Xcode output line by line whereas a failed test outputs at least 2 lines
of log: one that shows the failed test and the cause, another that
displays the duration (quite the same line as a passing test).
A considered approach would be to keep a context and output a
transformed log line only if the context is full (in the case of failed
tests, only if the cause and the duration have been parsed).