Handle uncaught exceptions #171

0xced · 2015-10-07T12:57:12Z

Here is my take on fixing #87.

houndci-bot · 2015-10-07T12:57:40Z

spec/xcpretty/formatters/formatter_spec.rb

+ 0 CoreFoundation 0x0000000109479a75 __exceptionPreprocess + 165
+ 1 libobjc.A.dylib 0x0000000109112bb7 objc_exception_throw + 45
+ 2 CoreFoundation 0x000000010938503f -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 383
+ 3 CoreFoundation 0x0000000109397d8b +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59


Tab detected.

supermarin · 2015-10-07T15:54:45Z

Thanks @0xced, this is awesome work!

Would you mind writing a feature for the crash as well?

kylef · 2015-10-07T16:24:24Z

I've just ran this this branch on my project throwing an exception and it doesn't catch my exception being thrown in XCTest since XCTest doesn't terminate the app but instead handle these and mark the test as failed.

UNCAUGHT_EXCEPTION_MATCHER only detects "Terminating app due to uncaught exception" where in my case xcodebuild prints:

`CCLFormat/NSAttributedStringFormatTests/NSAttributedString+CCLFormatTests.m:17: error: -[NSAttributedStringTests testAttributedFormatStringCanFormatAttributedString] : failed: caught "¯\_(ツ)_/¯", "¯\_(ツ)_/¯"`

Example Code:

- (void)testAttributedFormatStringCanFormatAttributedString {
    @throw [NSException exceptionWithName:@"¯\\_(ツ)_/¯" reason:@"¯\\_(ツ)_/¯" userInfo:nil];
}

Build settings from command line:
    SDKROOT = macosx10.11

=== BUILD TARGET NSAttributedStringFormat OF PROJECT NSAttributedStringFormat WITH CONFIGURATION Debug ===

Check dependencies

=== BUILD TARGET NSAttributedStringFormatTests OF PROJECT NSAttributedStringFormat WITH CONFIGURATION Debug ===

Check dependencies

Test Suite 'All tests' started at 2015-10-07 09:10:05.775
Test Suite 'NSAttributedStringFormatTests.xctest' started at 2015-10-07 09:10:05.777
Test Suite 'NSAttributedStringTests' started at 2015-10-07 09:10:05.777
Test Case '-[NSAttributedStringTests testAttributedFormatString]' started.
Test Case '-[NSAttributedStringTests testAttributedFormatString]' passed (0.006 seconds).
Test Case '-[NSAttributedStringTests testAttributedFormatStringCanFormatAttributedString]' started.
/Users/kyle/Projects/cocode/NSAttributedString-CCLFormat/NSAttributedStringFormatTests/NSAttributedString+CCLFormatTests.m:17: error: -[NSAttributedStringTests testAttributedFormatStringCanFormatAttributedString] : failed: caught "¯\_(ツ)_/¯", "¯\_(ツ)_/¯"
(
    0   CoreFoundation                      0x00007fff927d4bd2 __exceptionPreprocess + 178
    1   libobjc.A.dylib                     0x00007fff941484fa objc_exception_throw + 48
    2   NSAttributedStringFormatTests       0x0000000105b8d35a -[NSAttributedStringTests testAttributedFormatStringCanFormatAttributedString] + 314
    3   CoreFoundation                      0x00007fff927468cc __invoking___ + 140
    4   CoreFoundation                      0x00007fff9274675e -[NSInvocation invoke] + 286
    5   XCTest                              0x000000010585ab53 __24-[XCTestCase invokeTest]_block_invoke_2 + 159
    6   XCTest                              0x000000010588d026 -[XCTestContext performInScope:] + 184
    7   XCTest                              0x000000010585aaa3 -[XCTestCase invokeTest] + 169
    8   XCTest                              0x000000010585af3e -[XCTestCase performTest:] + 443
    9   XCTest                              0x0000000105858c0f -[XCTestSuite performTest:] + 377
    10  XCTest                              0x0000000105858c0f -[XCTestSuite performTest:] + 377
    11  XCTest                              0x0000000105858c0f -[XCTestSuite performTest:] + 377
    12  XCTest                              0x00000001058475c3 __25-[XCTestDriver _runSuite]_block_invoke + 51
    13  XCTest                              0x000000010586b736 -[XCTestObservationCenter _observeTestExecutionForBlock:] + 611
    14  XCTest                              0x000000010584750c -[XCTestDriver _runSuite] + 408
    15  XCTest                              0x00000001058480bb -[XCTestDriver _checkForTestManager] + 696
    16  XCTest                              0x000000010588e273 _XCTestMain + 628
    17  xctest                              0x0000000105838729 xctest + 5929
    18  libdyld.dylib                       0x00007fff90c945ad start + 1
)
Test Case '-[NSAttributedStringTests testAttributedFormatStringCanFormatAttributedString]' failed (0.421 seconds).
Test Case '-[NSAttributedStringTests testAttributedFormatStringCanFormatDescription]' started.
Test Case '-[NSAttributedStringTests testAttributedFormatStringCanFormatDescription]' passed (0.000 seconds).
Test Case '-[NSAttributedStringTests testAttributedFormatStringCanFormatString]' started.
Test Case '-[NSAttributedStringTests testAttributedFormatStringCanFormatString]' passed (0.000 seconds).
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatString]' started.
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatString]' passed (0.001 seconds).
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatAttributedString]' started.
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatAttributedString]' passed (0.000 seconds).
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatDescription]' started.
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatDescription]' passed (0.000 seconds).
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatMoreThanNineArgs]' started.
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatMoreThanNineArgs]' passed (0.000 seconds).
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatString]' started.
Test Case '-[NSAttributedStringTests testPositionalAttributedFormatStringCanFormatString]' passed (0.000 seconds).
Test Case '-[NSAttributedStringTests testPositionalFormatStringCanFormatRepeatedArgs]' started.
Test Case '-[NSAttributedStringTests testPositionalFormatStringCanFormatRepeatedArgs]' passed (0.000 seconds).
Test Suite 'NSAttributedStringTests' failed at 2015-10-07 09:10:06.213.
     Executed 10 tests, with 1 failure (1 unexpected) in 0.431 (0.436) seconds
Test Suite 'NSAttributedStringFormatTests.xctest' failed at 2015-10-07 09:10:06.214.
     Executed 10 tests, with 1 failure (1 unexpected) in 0.431 (0.437) seconds
Test Suite 'All tests' failed at 2015-10-07 09:10:06.215.
     Executed 10 tests, with 1 failure (1 unexpected) in 0.431 (0.439) seconds

Save the above to output.txt and run cat output.txt | xcpretty -c.

supermarin · 2015-10-07T16:25:31Z

Thanks @kylef !

Definitely worth adding a feature for both of these cases

supermarin · 2015-10-07T16:25:57Z

@0xced it might be worth checking the behavior with Swift as well

0xced · 2015-10-07T16:39:22Z

This pull request specifically addresses uncaught exceptions but of course it seems worth also handling caught exceptions! Do you think caught exceptions should also include the full call stack?

supermarin · 2015-10-07T17:21:10Z

@0xced I don't have a strong preference would it be 1 or 2 PRs.
If it doesn't add too much scope in this one it might be better to have it in :)

kylef · 2015-10-07T18:41:43Z

@0xced I'm unclear how you would get uncaught exceptions now that XCTest catches them internally. Are you using some other non-XCTest based testing framework?

0xced · 2015-10-07T19:08:02Z

@kylef Easy with some asynchronous code:

- (void) testUncaughtException
{
    XCTestExpectation *expectation = [self expectationWithDescription:@"I would expect that *all* exceptions are caught, but they aren’t…"];
    dispatch_async(dispatch_get_main_queue(), ^{
        [expectation fulfill];
        @throw [NSException exceptionWithName:@"Boom" reason:@"¯\\_(ツ)_/¯" userInfo:nil];
    });
    [self waitForExpectationsWithTimeout:1 handler:nil];
}

And here’s an in-depth explanation of why it’s not caught.

kylef · 2015-10-07T19:38:38Z

@0xced Thanks for clarifying, that makes sense. I have very few frameworks that are asynchronous and haven't came into this in a while.

0xced · 2015-10-08T08:59:24Z

Should I rebase on master and force push or is it going to make this PR very difficult to follow if I do so?

supermarin · 2015-10-08T14:27:04Z

Please feel welcome to go ahead Sir 🚀

houndci-bot · 2015-10-08T15:35:12Z

spec/xcpretty/parser_spec.rb

+ '-[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]',
+ [' 0 CoreFoundation 0x0000000109479a75 __exceptionPreprocess + 165',
+ ' 1 libobjc.A.dylib 0x0000000109112bb7 objc_exception_throw + 45',
+ ' 2 CoreFoundation 0x000000010938503f -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 383',


Line is too long. [139/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2015-10-08T15:35:14Z

spec/xcpretty/formatters/formatter_spec.rb

+
+\t0 CoreFoundation 0x0000000109479a75 __exceptionPreprocess + 165
+\t1 libobjc.A.dylib 0x0000000109112bb7 objc_exception_throw + 45
+\t2 CoreFoundation 0x000000010938503f -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 383


Line is too long. [126/80]

0xced · 2015-10-08T16:02:31Z

I just rebased on master. Should I consider Hound comments? I see plenty of other parts where single quoted strings are used and lies are too long.

supermarin · 2015-10-08T17:33:11Z

@0xced I've deleted some of them and @kattrali has worked recently on specifying this stuff better.
I'd say just keep going with your PR and when you're ready to merge we can review / decide

kattrali · 2015-10-12T19:31:16Z

It looks fine to me

Coder-256 · 2018-06-01T22:45:10Z

@supermarin What's the status on this?

houndci-bot reviewed Oct 7, 2015
View reviewed changes

0xced added 3 commits October 8, 2015 17:33

Handle uncaught exceptions - Fixes xcpretty#87

0dec7d6

Better uncaught exception formatting which includes the test case name

a119c28

Add "Running tests crash because of an uncaught exception" scenario

bf99910

0xced force-pushed the uncaught-exceptions branch from a2026ff to bf99910 Compare October 8, 2015 15:34

houndci-bot reviewed Oct 8, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle uncaught exceptions #171

Handle uncaught exceptions #171

0xced commented Oct 7, 2015

houndci-bot Oct 7, 2015

supermarin commented Oct 7, 2015

kylef commented Oct 7, 2015

supermarin commented Oct 7, 2015

supermarin commented Oct 7, 2015

0xced commented Oct 7, 2015

supermarin commented Oct 7, 2015

kylef commented Oct 7, 2015

0xced commented Oct 7, 2015

kylef commented Oct 7, 2015

0xced commented Oct 8, 2015

supermarin commented Oct 8, 2015

houndci-bot Oct 8, 2015

houndci-bot Oct 8, 2015

0xced commented Oct 8, 2015

supermarin commented Oct 8, 2015

kattrali commented Oct 12, 2015

Coder-256 commented Jun 1, 2018

Handle uncaught exceptions #171

Are you sure you want to change the base?

Handle uncaught exceptions #171

Conversation

0xced commented Oct 7, 2015

houndci-bot Oct 7, 2015

Choose a reason for hiding this comment

supermarin commented Oct 7, 2015

kylef commented Oct 7, 2015

supermarin commented Oct 7, 2015

supermarin commented Oct 7, 2015

0xced commented Oct 7, 2015

supermarin commented Oct 7, 2015

kylef commented Oct 7, 2015

0xced commented Oct 7, 2015

kylef commented Oct 7, 2015

0xced commented Oct 8, 2015

supermarin commented Oct 8, 2015

houndci-bot Oct 8, 2015

Choose a reason for hiding this comment

houndci-bot Oct 8, 2015

Choose a reason for hiding this comment

0xced commented Oct 8, 2015

supermarin commented Oct 8, 2015

kattrali commented Oct 12, 2015

Coder-256 commented Jun 1, 2018