Modernized Packages, multiple fixes #488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrflip
commented
Sep 22, 2022
mrflip
commented
- Updated packages to modern expo/react
- Typescript => 4.x
- the alpha scroll-to-a-letter thing works even in languages with many characters, with preferred countries, and with Åland
- search works with modern fuse, and will index against alternative names for the country
- buttons invalidate correctly when country code is changed (name and calling code were not updated)
- flag button still shows something even if all the button content options are off
- if search has no hits, text turns red and full list displays
- the side scroller no longer filters letters, it just jumps to list positions. the withAlphaFilter option has been removed, but will still toggle on/off the side scroller index if it is not explicitly set on or off.
- some async error handling" .
mrflip
force-pushed
the
ModernizedPkgsTypescript
branch
4 times, most recently
from
f558409
to
601ac5a
Compare
chore: integrated xcarpentier#475 from kanimetov chore: updated country code list fix: was recycling old names fix: added independent status
chore: integrated xcarpentier#475 from kanimetov
* the alpha scroll-to-a-letter thing works even in languages with many characters, with preferred countries, and with Åland * search works with modern fuse, and will index against alternative names for the country * buttons invalidate correctly when country code is changed (name and calling code were not updated) * flag button still shows something even if all the button content options are off * if search has no hits, text turns red and full list displays * the side scroller no longer filters letters, it just jumps to list positions. the withAlphaFilter option has been removed, but will still toggle on/off the side scroller index if it is not explicitly set on or off. * some async error handling
mrflip
force-pushed
the
ModernizedPkgsTypescript
branch
from
601ac5a
to
15dad71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.