Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings screen improvements #421

Open
wants to merge 6 commits into
base: 1.20.x
Choose a base branch
from

Conversation

seji1
Copy link

@seji1 seji1 commented May 24, 2024

This pr:

  • Cleans up some code
  • Adds all fields for translations (Uses vanilla fields, where possible, so no need to translate options, that are already translated in vanilla).
  • Makes gui scale a slider
  • Adds icon instead of "Video settings" text
  • Moves some settings into more sensible places
  • Fixes Unique opaque layer tooltip (thanks to thr)
  • Fixes a bug, where max possible gui scale was unavailable
  • Fixes a bug, where RangeOptionWidget played click sound when control is not hovered

Some screenshots with LOLCAT language (Vanilla fields are used and my test translation ones too):
image
image

Only vanilla fields, no translation:
image

@seji1 seji1 marked this pull request as draft May 25, 2024 15:10
@seji1 seji1 marked this pull request as ready for review May 26, 2024 10:39
@seji1
Copy link
Author

seji1 commented Jun 1, 2024

Resolves #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant