Skip to content

wytsai7660/OOP-hw2-3_fix

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

72 Commits
 
 
 
 
 
 
 
 
 
 

Repository files navigation

OOP HW2-3 Fix

This repository attempts to modernize JJK's code.

UML

Breaking Changes

In order to improve on JJK's code, the following breaking changes have been made (just a rough summary as it is a major rewrite so a lot of things have changed):

  • All mutators and accessors have been renamed to use snake_case instead of camelCase.
  • GET and SET has been modified to take one parameter only. The type of the property, the name of the accessor/mutator and the name of their parameters will be generated automatically. GET_WITH_NAME and SET_WITH_NAME were also added for customizing the generated accessor/mutator names.
  • All generators have been deleted. Templates are used in place of them for a more type-safe approach.
  • Almost all special members have become public because of the removal of generators.
  • *::generator::print functions have been moved to their enclosing classes of the inner classes they belong. For example, call header::print instead of header::generator:print. Except for event::generator::print, which have been moved to event::print_registered_event_types because there was already an event::print that did something different.
  • packet::discard has been removed since none of its members are dynamically allocated anymore.
  • node::add_phy_neighbor has been modified to take one parameter only since link's generator has been removed and the fact that simple_link is the only link type. If you would like to add more link types in the future, you can use std::variant and std::visit just like how we removed packet's generator.

Usage Guides

This is a major revamp of JJK's code, so there are some features that you need to access in a different way. The following list tries to list all of them.

  • Since all accessors now return const references, so you can't directly call a non-const function on the return value of a accessors. Instead, there are usually alternative functions that you can call to achieve the same effect:

    • Call IoT_ctrl_packet::increase_payload_counter instead of IoT_ctrl_payload::increase.
    • Call set_src_ID/set_dst_ID/set_pre_ID/set_nex_ID/set_msg on the packet directly instead of calling the getter for the header or payload on the packet and then setting them.
  • Since all generators have been removed, you should use the following constructors instead of generators:

    • Call the default constructor of the packet type you want to generate instead of packet::packet_generator::generate.
    • Call the copy/move constructor of the packet type you want to replicate instead of packet::packet_generator::replicate.
  • Use the variant type node::PacketTypes and std::visit instead of packet * and downcasting.

  • Instead of calling node::generator::generate, call IoT_device::generate.

  • Instead of calling link::generator::generate, call simple_link::generate.

  • Instead of calling event::generator::generate, call <event-type>::generate.

  • Instead of accessing event::trigger_time directly, call get_trigger_time/set_trigger_time.

About

fix this buggy code

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published

Languages