Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filePath option #13

Closed
wants to merge 1 commit into from
Closed

Add filePath option #13

wants to merge 1 commit into from

Conversation

karaggeorge
Copy link
Member

Adds a filePath option which allows you to control where the file is created.

Will be needed for issues like wulkano/Kap#871

@sindresorhus
Copy link
Member

sindresorhus commented Jun 27, 2020

See the comments in #11

@karaggeorge
Copy link
Member Author

So, should I add some kind of documentation? In this case, that is the desired behavior. People want this so if your computer/kap crashes, you at least have that file in a location you know, so maybe they can salvage it, so I don't think using the tmp and moving at the end would solve that

@sindresorhus
Copy link
Member

Yes. Docs. Per #7 (comment).

In this case, that is the desired behavior. People want this so if your computer/kap crashes, you at least have that file in a location you know, so maybe they can salvage it, so I don't think using the tmp and moving at the end would solve that

The point isn't that it solves that use-case. The point is that the recommended default should be temp and if an app wants, they can let the user customize it. Your computer crashing is an edge-case and it's better to document the temp location instead of an option, in my opinion.

@sindresorhus
Copy link
Member

Bump

1 similar comment
@sindresorhus
Copy link
Member

Bump

@karaggeorge
Copy link
Member Author

I don't think we need this anymore? I think we fixed this issue in Kap the right way. We could close until another need for it arises?

@sindresorhus sindresorhus deleted the file-path branch November 18, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants