Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1095 Use different library for screen capture permission #1134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thethomasz
Copy link
Contributor

Hopefully fixes #1095 while side stepping the issues in https://github.com/karaggeorge/mac-screen-capture-permissions/releases/tag/v2.0.0. This new package doesn't know if it has already asked for permission though, so on initial load, 2 dialogs will pop up. I'm thinking of adding something similar to what the old library had where it saves whether it has already asked before, but wanted to see if it's even necessary to update the package first.

@sindresorhus
Copy link
Member

Make sure you have done this:

If someone wants to work on this, make sure you test the change by running npm run dist and try launching the app in the dist folder.

@thethomasz thethomasz force-pushed the issue-1095-update-permissions-package branch from 4061f44 to 148d9c1 Compare August 28, 2022 05:31
@thethomasz
Copy link
Contributor Author

Hmm, not sure why, but just realized that this package doesn't seem to be giving permissions correctly? It'll ask for permissions twice, once when the app is first opened, and another time when the user actually starts a screen recording.

Screen Shot 2022-08-27 at 10 42 04 PM

The first one in the screenshot above is the one required to actually capture the screen, and the one below doesn't do anything at all. Might need some help with this one.

@thethomasz thethomasz force-pushed the issue-1095-update-permissions-package branch from 148d9c1 to 3d75c9d Compare August 28, 2022 06:18
@thethomasz thethomasz force-pushed the issue-1095-update-permissions-package branch from 3d75c9d to 34ad95b Compare August 29, 2022 02:33
@timothyis
Copy link
Member

For the development and production versions, perhaps?

@thethomasz
Copy link
Contributor Author

For the development and production versions, perhaps?

Hmm, I'm not sure what you mean. Lemme write out the steps I did to reproduce this, maybe my comment wasn't clear.

  1. I removed all apps from having screen capture permissions
  2. Ran npm run dist to build the app, and installed it
  3. Opened Kap which would then prompt me to give it screen capture permissions
  4. After I give it permissions and restart the app, the cropper window appears and I can start recording
  5. When I hit record, another prompt asking for screen capture permissions appears

It shouldn't prompt for a second time, but not sure what I'm doing wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mac-screen-capture-permissions causing Unhandled Promise Rejection
3 participants