Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change getBoundingClientRect from offsetwidth #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NaokiFujikawa
Copy link

"offsetwidth" is round the value to an intege. So I want you to use "getBoundingClientRect".

https://developer.mozilla.org/ja/docs/Web/API/Element/getBoundingClientRect

The same thing happens with the issue below in the scroll view.
ant-design/ant-design#25300 (comment)

change offsetHeight to BoundingClientRect().height
@wubostc
Copy link
Owner

wubostc commented Oct 12, 2020

@NaokiFujikawa
i will pay attention to this issue

@wubostc
Copy link
Owner

wubostc commented Oct 12, 2020

@NaokiFujikawa
i will pay attention to this issue

can you put some examples on https://codesandbox.io which can show the differences that you said.

@NaokiFujikawa
Copy link
Author

Thank you for your interest.
I made a sample for you. https://codesandbox.io/s/pull73-forked-oscod

This is caused by changing the display settings
The differences in the display settings are shown below.

When the display setting is 100%, there is no problem.
display100
100

But it occurs when you set it to 125%. The scroll bar will be active.
display125
125

@wubostc
Copy link
Owner

wubostc commented Oct 16, 2020

this commit has a big problem...
it will cause the height of each tr to be increased by 1

@wubostc
Copy link
Owner

wubostc commented Oct 16, 2020

the main problem at present is that there is no way to set a floating-number for css...

@NaokiFujikawa
Copy link
Author

Thank you for checking.

I see. I'm fine in my use, but I didn't think about PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants