Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated heat transfer coefficient correlation parameters for horizontal and upward heat flow over PV panels. #2049

Open
wants to merge 1 commit into
base: release-v4.6.1
Choose a base branch
from

Conversation

joshi994
Copy link
Contributor

TYPE: Bug fix

KEYWORDS: PV panels, Correlations, Upward heat flow, Surface angle, Heat transfer coefficient, BEM (Building Energy Model).

SOURCE: Parag Joshi (Brookhaven National Laboratory)

DESCRIPTION OF CHANGES:
Problem:
A typographical mistake was identified within the correlations that evaluate heat transfer coefficient for the upward heat flow over PV panels in the Building Energy Model (BEM).

Solution:
The parameters have been modified following the correlation expressions provided in the literature.

ISSUE: For use when this PR closes an issue.
Fixes #123

LIST OF MODIFIED FILES: module_sf_bem.F

TESTS CONDUCTED:

  1. No test has been conducted as the parameters seems to have very small or insignificant impact on the results. However, the tests can be performed with and without correcting the parameters to quantify the role.

Please refer to the equation J.2.2a (please see the attached screenshot) on page number 79 of the document below.
https://nvlpubs.nist.gov/nistpubs/Legacy/IR/nbsir83-2655.pdf

Screenshot 2024-05-14 at 5 07 59 PM

RELEASE NOTE: Parameters associated with the evaluation of heat transfer coefficient for the upward heat flow case are corrected.

…coefficient for the upward/downward transport of heat are corrected.
@joshi994 joshi994 requested a review from a team as a code owner May 14, 2024 21:10
@weiwangncar
Copy link
Collaborator

The regression test results:
Test Type | Expected | Received | Failed
= = = = = = = = = = = = = = = = = = = = = = = = = = = =
Number of Tests : 23 24
Number of Builds : 60 57
Number of Simulations : 158 150 0
Number of Comparisons : 95 86 0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator

@joshi994 Please hold off any update to this PR or any new PR, as we are going to update the regression tests in the next few weeks. Thanks!

@dudhia
Copy link
Collaborator

dudhia commented May 16, 2024

This PR is to master and should go to develop until we have a 4.6.1 branch

@islas islas changed the base branch from master to release-v4.6.1 May 16, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants