Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash that occurs when remove a user #20837

Merged
merged 4 commits into from
May 20, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented May 16, 2024

This fixes some parts of #20535.

The crash message is Can not perform this action after onSaveInstanceState.

This PR adds a check for the fragment's state and doesn't run the fragmentManager.popBackStack(); if the fragment's state is saved.


To Test:

  1. Log in.
  2. Tap more button on "My Site".
  3. Tap People.
  4. Tap a user item.
  5. Tap the trash icon at the top right to remove the user.
  6. Tap the REMOVE button on the dialog but go to device home immediately after tapping the REMOVE button.
  7. on trunk this should cause a crash with Can not perform this action after onSaveInstanceState message. Ensure it doesn't crash on this PR.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • This is a very hard case to reproduce. Not a proper case for UI tests.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20837-69a8ccc
Commit69a8ccc
Direct Downloadjetpack-prototype-build-pr20837-69a8ccc.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20837-69a8ccc
Commit69a8ccc
Direct Downloadwordpress-prototype-build-pr20837-69a8ccc.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@aditi-bhatia aditi-bhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the crash on trunk and the fix works as expected 👍

Copy link

sonarcloud bot commented May 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@irfano irfano merged commit 462931c into trunk May 20, 2024
20 checks passed
@irfano irfano deleted the issue/20535-fix-a-crash-on-peple-screen branch May 20, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalStateException: Can not perform this action after onSaveInstanceState
3 participants