Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Run Danger on the Linter Agent #20807

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented May 13, 2024

This PR uses the new Linter Agent on Buildkite to run the Danger jobs.

Because Danger will now run on Buildkite, this PR uses a new GitHub Actions workflow (see Automattic/dangermattic#64 for more details) to retry the Buildkite jobs when the PR state (such as the milestone and labels) changes.

@iangmaia iangmaia requested a review from mokagio May 13, 2024 19:13
@iangmaia iangmaia self-assigned this May 13, 2024
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20807-568ab66
Commit568ab66
Direct Downloadjetpack-prototype-build-pr20807-568ab66.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20807-568ab66
Commit568ab66
Direct Downloadwordpress-prototype-build-pr20807-568ab66.apk
Note: Google Login is not supported on these builds.

@iangmaia iangmaia added this to the 25.0 milestone May 14, 2024
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other Linter CI queue setup PRs 👌

@iangmaia we'll need to update the required GitHub checks after merging this to remove the superseded dangermattic/dangermattic

image

@mokagio mokagio removed the Tooling label May 20, 2024
@mokagio
Copy link
Contributor

mokagio commented May 20, 2024

Toggling the "tooling" label to see the GitHub Action - Buildkite - GitHub comment integration at play.

@iangmaia iangmaia merged commit 4e33f4a into trunk May 20, 2024
24 checks passed
@iangmaia iangmaia deleted the iangmaia/linter-agent branch May 20, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants