Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @types/leb128 #62

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add @types/leb128 #62

merged 1 commit into from
Jan 15, 2024

Conversation

remcohaszing
Copy link
Contributor

There’s no need anymore to use @ts-expect-error for the leb128 import, or to cast the types its functions return.

There’s no need anymore to use `@ts-expect-error` for the `leb128` import,
or to cast the types its functions return.
@wooorm
Copy link
Owner

wooorm commented Jan 15, 2024

Thanks for the types but it’s just a little script that I saved here for future reference for when Node supports WASM I can actually implement it. It doesn’t run.
Not sure if leb128 is needed then. It seems useful but also not maintained? 🤷‍♂️

Feels a bit weird to add dev-dependencies that aren’t used?

@wooorm
Copy link
Owner

wooorm commented Jan 15, 2024

Oh I guess TS still checks it all?

@wooorm wooorm changed the title Add missing leb128 and @types/leb128 dependencies Add @types/leb128 Jan 15, 2024
@wooorm wooorm merged commit 5ee9325 into wooorm:main Jan 15, 2024
1 check passed
@remcohaszing remcohaszing deleted the leb128-dependencies branch January 15, 2024 12:30
@remcohaszing
Copy link
Contributor Author

Technically you could use @types/leb128, but not leb128 if it’s just for TypeScript. Personally I would keep it, as it’s needed to run a script that is part of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants