Make RsaPad/UnPad available when -DWOLFSSL_PUBLIC_MP set #7366
Conversation
| @@ -434,11 +434,11 @@ WOLFSSL_API int wc_RsaExportKey(RsaKey* key, | |||
| int nlen, int* isPrime); | |||
| #endif | |||
|
|
|||
| WOLFSSL_LOCAL int wc_RsaPad_ex(const byte* input, word32 inputLen, byte* pkcsBlock, | |||
| MP_API int wc_RsaPad_ex(const byte* input, word32 inputLen, byte* pkcsBlock, | |||
There was a problem hiding this comment.
I thought MP was for multi precision and related to the math library API's. Why was MP_API chosen here?
There was a problem hiding this comment.
MP_API allows this function to be public (non-opaque / WOLFSSL_API) when -DWOLFSSL_PUBLIC_MP is defined. Otherwise MP_API defaults to opaque (WOLFSSL_LOCAL). MP_API was selected as the "configurable" visibility option.
There was a problem hiding this comment.
From wolfmath.h:
36 #ifdef WOLFSSL_PUBLIC_MP
37 #define MP_API WOLFSSL_API
38 #else
39 #define MP_API WOLFSSL_LOCAL
40 #endif
There was a problem hiding this comment.
Following an internal discussion we will instead make a brand new public accessor function instead of making the opaqueness of the API configurable.
| @@ -434,11 +434,11 @@ WOLFSSL_API int wc_RsaExportKey(RsaKey* key, | |||
| int nlen, int* isPrime); | |||
| #endif | |||
|
|
|||
| WOLFSSL_LOCAL int wc_RsaPad_ex(const byte* input, word32 inputLen, byte* pkcsBlock, | |||
| MP_API int wc_RsaPad_ex(const byte* input, word32 inputLen, byte* pkcsBlock, | |||
There was a problem hiding this comment.
My preference would be to make these public all the time going forward.
Description
Customer requested this change, being tracked under OE addition effort and was scheduled to go into master as part of OE check-in. However, FIPS cert is taking longer than anticipated, OE work is feature complete but only gets checked-in when approved by CSTL review. The customer is eager to see this in the next release.
Testing
N/A
Checklist