XCODE support for v5.2.3 of the FIPS module #7140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lealem47
approved these changes
Jan 18, 2024
|
Jenkins Retest this please |
kaleb-himes
force-pushed
the
140-3-ARMv8-PAA-porting
branch
from
1bb0142
to
c20951b
Compare
kaleb-himes
changed the title
|
NOTE: After internal versioning discussion, changing version to v5.2.3 from v5.3.0 which is in contention with fips-ready and fips-dev |
| @@ -374,6 +432,7 @@ extern "C" { | |||
| #undef WOLFSSL_SHA3 | |||
| #if 1 | |||
| #define WOLFSSL_SHA3 | |||
| #define Sha3 wc_Sha3 | |||
There was a problem hiding this comment.
This should be handled in wolfssl/wolfcrypt/sha3.h as long as NO_OLD_WC_NAMES is not defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some warnings found by XCODE and adds options for customer(s) who will be depending on v5.3.0 of the FIPS module.
Testing
See fips repo for test applications, full harness and optesting done in-house, ready to go to a CSTL for review
Checklist