Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.19.0 release #399

Merged
merged 1 commit into from
Mar 22, 2024
Merged

v1.19.0 release #399

merged 1 commit into from
Mar 22, 2024

Conversation

embhorn
Copy link
Member

@embhorn embhorn commented Mar 22, 2024

Update version and release year
Fix scan-build issue in multithread example

@embhorn embhorn self-assigned this Mar 22, 2024
@embhorn embhorn requested a review from dgarske March 22, 2024 17:06
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add change log for release.

configure.ac Outdated
@@ -24,7 +24,7 @@ AC_ARG_PROGRAM
AC_CONFIG_MACRO_DIR([m4])
AC_CONFIG_HEADERS([src/config.h])

WOLFMQTT_LIBRARY_VERSION=17:0:0
WOLFMQTT_LIBRARY_VERSION=18:0:0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to change the DLL major version. This version is not meant to be in sync with our v1.19.0. I recommend making this 17:1:0.

@embhorn embhorn force-pushed the v1.19.0_rel_prep branch 2 times, most recently from 689ec1b to 579d095 Compare March 22, 2024 17:48
@embhorn embhorn requested review from dgarske and removed request for dgarske March 22, 2024 18:03
@dgarske dgarske merged commit 06a7812 into wolfSSL:master Mar 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants