Add mouse wheel setting #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now mouse wheel can switch between: (default) wheel: zoom and ctrl+wheel: next/prev and wheel: next/prev and ctrl+wheel: zoom
|
Sorry for the delay! First of all, thank you for this PR! I really like this feature. I am thinking if we could solve this in a more generic way - for example could we maybe just expose wheel up and wheel down and have users set his directly, by setting shift + scroll to a specific action? What do you think? |
|
Thanks for the comment! I implemented a better UI for the setting.
In the screenshot, settings are changed from the default to showcase the various UI states, but the default behavior isn't changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mouse wheel and ctrl-wheel are statically assigned to zooming in/out and moving to next/prev image respectively.
With this PR, users will be able to swap these assignments.
Changes
mouse_wheel_actionMousesection in the preferences UI for changing the setting (screenshot below)New behavior
Zoomselected (default), mouse wheel works as zoom in/out and ctrl-wheel works as next/prev.Next/Prevselected, mouse wheel works as next/prev and ctrl-wheel works as zoom in/out.