Sensostar storageNr fix #868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sensostar heatmeter has 30 storage positions for storing energy consuption values. Every semi-month a new value is written to the storageNr 2 and the following values are pushed down one position. This applies even when the meter in configured for monthly storage. In this case the telegrams contain values from every second storage position, these are (in the first half of the month) storageNr 2, 4, 6, etc. and in the second half storageNr 3, 4, 5, etc. This fix corrects the storageNr handling in the sensostar driver.
|
Hi, please check code - test cases are chopped of at the end. |
|
Fixed issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensostar heatmeter has 30 storage positions for storing energy consuption values. Every semi-month a new value is written to the storageNr 2 and the following values are pushed down one position. This applies even when the meter in configured for monthly storage. In this case the telegrams contain values from every second storage position, these are (in the first half of the month) storageNr 2, 4, 6, etc. and in the second half storageNr 3, 4, 5, etc. This fix corrects the storageNr handling in the sensostar driver to get a subsequent list of values in the first and second semi-month.