Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: Update the documentation for the output param #347

Merged
merged 1 commit into from May 12, 2024

Conversation

abouelkhair5
Copy link
Contributor

@abouelkhair5 abouelkhair5 commented Apr 24, 2024

  • I updated the description for the output parameter to indicate that it can be a directory
  • Currently it only shows it can be the file name
  • Original PR to make the code change is Support giving directory as output #66

@abouelkhair5 abouelkhair5 changed the title Update the documentation for the output param Trivial: Update the documentation for the output param Apr 24, 2024
@wkentaro
Copy link
Owner

Thanks!

@wkentaro wkentaro merged commit 20e803d into wkentaro:main May 12, 2024
@wkentaro wkentaro self-assigned this May 12, 2024
@wkentaro wkentaro added the other for pr label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other for pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants