feat: ✨ pass down resume to download_folder #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good to merge right ? |
|
Indeed I've been using it as the gdown version in a project here: https://github.com/melmass/comfy_mtb |
achadwick
added a commit
to achadwick/gdown
that referenced
this pull request
Dec 14, 2023
Allow folder mode to pass through the resume flag. This still makes some unnecessary requests, however. Duplicates wkentaro#275, but also updates cli.py appropriately.
|
This alone doesn't change the behaviour enough to make the feature useful to me, sadly 😞
I've tried to address these in #288 in case folks are interested in that. |
|
I don't use the CLI, just the module but I will close this, I don't think they are interested anyway, and it's a 2 line fix |
achadwick
added a commit
to achadwick/gdown
that referenced
this pull request
Feb 17, 2024
Allow folder mode to pass through the resume flag. This still makes some unnecessary requests, however. Duplicates wkentaro#275, but also updates cli.py appropriately.
wkentaro
pushed a commit
to achadwick/gdown
that referenced
this pull request
May 12, 2024
Allow folder mode to pass through the resume flag. This still makes some unnecessary requests, however. Duplicates wkentaro#275, but also updates cli.py appropriately.
wkentaro
pushed a commit
that referenced
this pull request
May 12, 2024
Allow folder mode to pass through the resume flag. This still makes some unnecessary requests, however. Duplicates #275, but also updates cli.py appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't change the default behaviour but allow for resumable files inside a folder