Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commerce Layer spec #2316

Merged
merged 12 commits into from Apr 29, 2024
Merged

Commerce Layer spec #2316

merged 12 commits into from Apr 29, 2024

Conversation

pviti
Copy link
Contributor

@pviti pviti commented Apr 11, 2024 •
edited

Add Commerce Layer spec

@withfig-bot
Copy link
Collaborator

withfig-bot commented Apr 11, 2024 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Collaborator

withfig-bot commented Apr 11, 2024 •
edited

Overview

src/cl.ts:

Info:

src/commercelayer.ts:

Info:

URLs:

  • https://data.commercelayer.app/seeder
  • https://data.commercelayer.app/seeder
  • https://data.commercelayer.app/seeder

@withfig-bot
Copy link
Collaborator

Hello @pviti,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@pviti pviti marked this pull request as draft April 11, 2024 14:28
@pviti
Copy link
Contributor Author

pviti commented Apr 11, 2024

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Apr 11, 2024
@withfig-bot
@pviti has signed the CLA in #2316
ada5a92
@pviti pviti marked this pull request as ready for review April 15, 2024 11:39
@pviti pviti changed the title CommerceLayer spec Commerce Layer spec Apr 18, 2024
@grant0417 grant0417 merged commit 74c8987 into withfig:master Apr 29, 2024
5 checks passed
@withfig withfig locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grant0417 grant0417 grant0417 approved these changes

@mschrage mschrage Awaiting requested review from mschrage mschrage is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pviti @withfig-bot @grant0417