Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(atuin): add spec) #2122

Merged
merged 1 commit into from Oct 27, 2023
Merged

feat(atuin): add spec) #2122

merged 1 commit into from Oct 27, 2023

Conversation

Fall1ngStar
Copy link
Contributor

Solves #2121

@withfig-bot
Copy link
Collaborator

withfig-bot commented Oct 14, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Collaborator

Overview

src/atuin.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @Fall1ngStar,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@Fall1ngStar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Oct 14, 2023
@withfig-bot
@Fall1ngStar has signed the CLA in #2122
9fdb916
grant0417
grant0417 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@grant0417 grant0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grant0417 grant0417 merged commit b41d541 into withfig:master Oct 27, 2023
4 of 5 checks passed
@withfig withfig locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grant0417 grant0417 grant0417 approved these changes

@mschrage mschrage Awaiting requested review from mschrage mschrage is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fall1ngStar @withfig-bot @grant0417