Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rspec): Add rspec #2113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zeko369
Copy link
Contributor

@Zeko369 Zeko369 commented Oct 2, 2023

No description provided.

@withfig-bot
Copy link
Collaborator

withfig-bot commented Oct 2, 2023

Overview

src/rspec.ts:

Info:

URLs:

  • https://rspec.info/images/logo.png

@withfig-bot
Copy link
Collaborator

Hello @Zeko369,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@grant0417
Copy link
Member

Is there more to rspec? I know you just started this last week but LMK when you are finished!

@Zeko369
Copy link
Contributor Author

Zeko369 commented Dec 2, 2023

Hey @grant0417, finally done with this

@Zeko369 Zeko369 marked this pull request as ready for review December 2, 2023 21:37
},
},
{
name: ["--bisect[=verbose]", "--bisect"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=verbose should be an argument with requiresequals

exclusiveOn: ["--fail-fast"],
},
{
name: ["--fail-fast", "--fail-fast=COUNT"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also an argument with requiresequals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants