Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rails): Missing db commands and runner #2112

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Zeko369
Copy link
Contributor

@Zeko369 Zeko369 commented Oct 2, 2023

No description provided.

@Zeko369 Zeko369 requested a review from mschrage as a code owner October 2, 2023 12:25
@withfig-bot
Copy link
Collaborator

withfig-bot commented Oct 2, 2023

Overview

src/rails.ts:

Info:

URLs:

  • https://raw.githubusercontent.com/vscode-icons/vscode-icons/master/icons/file_type_ruby.svg
  • https://avatars.githubusercontent.com/u/4223?s=48&v=4

@withfig-bot
Copy link
Collaborator

Hello @Zeko369,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

src/rails.ts Outdated
args: {
name: "environment",
generators: {
script: "ls config/environments",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file also relative to the command being run? Is is possible it is in some parent directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I've setup a command to do that (I think we also mention this in another one of my PRs)

I'd want to extract this since I want to use it on other pending PRs + refactor some of the other CLIs so I'd move it to @withfig/autocomplete-tools or to a share lib file in this repo?

Thoughs?

Function -> https://github.com/withfig/autocomplete/pull/2112/files#diff-34f5c090cacdca031210e68db93072f048a5d6f31428fe107d0fdcbd19da4803R6-R50

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC extraction of this function by @mschrage
#2077 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants