Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update config to pin dep version for new deps additions #1978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddanielcruzz
Copy link
Contributor

@ddanielcruzz ddanielcruzz commented May 18, 2023

This is just a suggestion that when new packages are added to the repo they are pinned to specific version rather than using the caret (^) and allowing to install different minor versions.

My reasons are:

  • Dependencies could could mess up semver and introduce breaking changes in minor/patches updates
  • Having pinned dependencies makes sure everyone contributing has the same exact versions, making it easier for everyone to debug
  • Avoid constantly update yarn.lock when people install deps. Since minor versions are allowed yarn.lock changes unless contributors install deps with --fozen-lockfile flag (yarn install --frozen-lockfile)

This just changes the behavior for new packages added. package.json would still need to be updated to remove the caret from all deps that have it, but first I wanted to introduce the idea of pinned versions before proceeding to update pacakge.json

@ddanielcruzz ddanielcruzz changed the title deps: update config to fix dep version for new deps additions deps: update config to pin dep version for new deps additions May 22, 2023
@ddanielcruzz
Copy link
Contributor Author

@fedeci just a friendly ping in case you missed this 😄

@grant0417
Copy link
Member

Hey @ddanielcruzz, sorry about the delay on this! I like the idea and am open to merge if you remove the ^ from the deps.

@grant0417 grant0417 added the needs-change The user needs to make some change before merge label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-change The user needs to make some change before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants