New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for minikube, terragrunt, tgenv #1014
base: master
Are you sure you want to change the base?
Conversation
Overviewsrc/terragrunt.ts:Info:src/tgenv.ts:Info:Script: function (out) {
return out
.trim()
.split("\n")
.map((tfversion) => {
return { name: tfversion, description: "Version" };
});
} Script: function (out) {
return out
.trim()
.split("\n")
.map(function (line) {
return { name: line, type: "option" };
});
} src/minikube.ts:Info: |
Hello @yinchuandong,
Please add a 👍 as a reaction to this comment to show that you read this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are options with the equal valid when no equal is specified? If they are not we should add requiresEqual: true
Thanks for opening this PR! |
src/terragrunt.ts
Outdated
args: { | ||
template: "filepaths", | ||
suggestCurrentToken: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fedeci , these terragrunt global options don't require equal. referring to https://terragrunt.gruntwork.io/docs/reference/cli-options/#all-terraform-built-in-commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @yinchuandong! If the equals are not mandatory can you remove the insertValue
s that insert those? I honestly find cleaner options without equals.
Hi @fedeci , thanks for your suggestion! I got what you mean. But Reference |
We'll move insertionValue changes to another PR :)
Hey @yinchuandong! Sorry for the slow response here. I am not sure why this wasn't merged in. Could you sign our CLA (and ideally fix the conflicts) and I will merge this ASAP. |
recheck |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Hi @yinchuandong - know it's been a while, but we would love to get this merged! Could you please sign the CLA and get these small conflicts fixed? We'd love to give you merge credit :) |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
New Features:
minikube dashboard
subcommandterragrunt
supporttgenv
supportWhat is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Additional info: