Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: i18n domains #8285

Merged
merged 5 commits into from
May 22, 2024
Merged

feat: i18n domains #8285

merged 5 commits into from
May 22, 2024

Conversation

ematipico
Copy link
Member

Description (required)

This PR makes domains stable, and moves the section before the manual routing.

For Astro version: 4.9.0. See astro PR #11022.

@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:25am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 22, 2024 0:25am

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 15, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/internationalization.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ematipico ematipico mentioned this pull request May 15, 2024
Merged
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels May 15, 2024
@sarah11918 sarah11918 added this to the 4.9.0 milestone May 15, 2024
sarah11918
sarah11918 approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just removed the line in the text about adding the experimental flag, and this should be good to go! 🥳

src/content/docs/en/guides/internationalization.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 17, 2024
@sarah11918 sarah11918 mentioned this pull request May 22, 2024
Merged
@sarah11918 sarah11918 changed the base branch from main to 4.9.0 May 22, 2024 12:15
@sarah11918 sarah11918 merged commit 51f4d61 into 4.9.0 May 22, 2024
2 of 3 checks passed
@sarah11918 sarah11918 deleted the feat/i18n-domains branch May 22, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ematipico @astrobot-houston @sarah11918