Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Starlight's Tabs #8196

Merged
merged 5 commits into from
May 21, 2024
Merged

feat: use Starlight's Tabs #8196

merged 5 commits into from
May 21, 2024

Conversation

liruifengv
Copy link
Sponsor Member

@liruifengv liruifengv commented May 7, 2024 •
edited

Description (required)

  • Use Starlight's Tabs component

Related issues & labels (optional)

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 21, 2024 1:27am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 7, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 7, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de guides/typescript.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@liruifengv
Copy link
Sponsor Member Author

Wait for the next Starlight version ⭐

@liruifengv liruifengv marked this pull request as draft May 7, 2024 08:39
@at-the-vr
Copy link
Contributor

Hey liruifengv is your PR conflicting with #8322?

@delucis
Copy link
Member

delucis commented May 17, 2024

Ah, sorry, I’d forgotten about this PR when making #8322. But I think it can still be useful.

  1. We can merge Update Starlight and Astro to latest versions #8322
  2. Then we can use this PR to migrate to Starlight’s Tabs, which is super helpful!

@liruifengv
Copy link
Sponsor Member Author

Ah, sorry, I’d forgotten about this PR when making #8322. But I think it can still be useful.

  1. We can merge Update Starlight and Astro to latest versions #8322

  2. Then we can use this PR to migrate to Starlight’s Tabs, which is super helpful!

No problem. I will update this PR after merge #8322

@delucis
Copy link
Member

delucis commented May 18, 2024

#8322 is merged — it’s all yours @liruifengv! 🚀

@liruifengv liruifengv changed the title feat: upgrade Starlight to 0.22.2 & use Starlight's Tabs feat: use Starlight's Tabs May 20, 2024
@liruifengv liruifengv marked this pull request as ready for review May 20, 2024 02:23
TheOtterlord
TheOtterlord approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on a handful of pages, including the shared state recipe.

delucis
delucis approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic and the sync feature is working well even on more complex content like the “Sharing state” recipe.

Thank you @liruifengv! 💖

@delucis delucis added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 20, 2024
@liruifengv
Copy link
Sponsor Member Author

Thank y'all!

@liruifengv
Copy link
Sponsor Member Author

!coauthor

@github-actions GitHub Actions
Copy link 

Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Atharva <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Reuben Tier <[email protected]>

@liruifengv liruifengv merged commit d825b1c into withastro:main May 21, 2024
8 checks passed
@liruifengv liruifengv deleted the upgrade-startlight-0.22 branch May 21, 2024 01:38
@liruifengv
Copy link
Sponsor Member Author

Oh.. I got the coauthors, but I forget add them when merge. Lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@TheOtterlord TheOtterlord TheOtterlord approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liruifengv @astrobot-houston @at-the-vr @delucis @TheOtterlord