Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ko-KR): use <Steps> components for many files. #8171

Merged
merged 33 commits into from
May 20, 2024

Conversation

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 20, 2024 6:34pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 3, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 3, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ko guides/cms/builderio.mdx Localization changed, will be marked as complete. 🔄️
ko guides/cms/buttercms.mdx Localization changed, will be marked as complete.
ko guides/cms/contentful.mdx Localization changed, will be marked as complete.
ko guides/cms/cosmic.mdx Localization changed, will be marked as complete.
ko guides/cms/datocms.mdx Localization changed, will be marked as complete.
ko guides/cms/decap-cms.mdx Localization changed, will be marked as complete.
ko guides/cms/hygraph.mdx Localization changed, will be marked as complete.
ko guides/cms/keystatic.mdx Localization changed, will be marked as complete.
ko guides/cms/kontent-ai.mdx Localization changed, will be marked as complete.
ko guides/cms/payload.mdx Localization changed, will be marked as complete.
ko guides/cms/preprcms.mdx Localization changed, will be marked as complete.
ko guides/cms/sitecore.mdx Localization changed, will be marked as complete.
ko guides/cms/spinal.mdx Localization changed, will be marked as complete.
ko guides/cms/storyblok.mdx Localization changed, will be marked as complete.
ko guides/cms/strapi.mdx Localization changed, will be marked as complete.
ko guides/cms/tina-cms.mdx Localization changed, will be marked as complete.
ko guides/deploy/aws.mdx Localization changed, will be marked as complete.
ko guides/deploy/buddy.mdx Localization changed, will be marked as complete.
ko guides/deploy/cleavr.mdx Localization changed, will be marked as complete.
ko guides/deploy/cloudflare.mdx Localization changed, will be marked as complete.
ko guides/deploy/deno.mdx Localization changed, will be marked as complete.
ko guides/deploy/edgio.mdx Localization changed, will be marked as complete.
ko guides/deploy/flightcontrol.mdx Localization changed, will be marked as complete.
ko guides/deploy/flyio.mdx Localization changed, will be marked as complete.
ko guides/deploy/github.mdx Localization changed, will be marked as complete.
ko guides/deploy/gitlab.mdx Localization changed, will be marked as complete.
ko guides/deploy/google-cloud.mdx Localization changed, will be marked as complete.
ko guides/deploy/google-firebase.mdx Localization changed, will be marked as complete.
ko guides/deploy/heroku.mdx Localization changed, will be marked as complete.
ko guides/deploy/kinsta.mdx Localization changed, will be marked as complete.
ko guides/deploy/microsoft-azure.mdx Localization changed, will be marked as complete.
ko guides/deploy/netlify.mdx Localization changed, will be marked as complete. 🔄️
ko guides/deploy/render.mdx Localization changed, will be marked as complete. 🔄️
ko guides/deploy/space.mdx Localization changed, will be marked as complete.
ko guides/deploy/sst.mdx Localization changed, will be marked as complete.
ko guides/deploy/stormkit.mdx Localization changed, will be marked as complete.
ko guides/deploy/surge.mdx Localization changed, will be marked as complete.
ko guides/deploy/vercel.mdx Localization changed, will be marked as complete. 🔄️
ko guides/deploy/zeabur.mdx Localization changed, will be marked as complete.
ko guides/ecommerce.mdx Localization changed, will be marked as complete.
ko guides/integrations-guide/markdoc.mdx Localization changed, will be marked as complete.
ko guides/markdown-content.mdx Localization changed, will be marked as complete. 🔄️
ko guides/middleware.mdx Localization changed, will be marked as complete. 🔄️
ko guides/migrate-to-astro/from-gatsby.mdx Localization changed, will be marked as complete.
ko guides/migrate-to-astro/from-nextjs.mdx Localization changed, will be marked as complete.
ko guides/migrate-to-astro/from-nuxtjs.mdx Localization changed, will be marked as complete.
ko guides/rss.mdx Localization changed, will be marked as complete.
ko guides/server-side-rendering.mdx Localization changed, will be marked as complete.
ko guides/testing.mdx Localization changed, will be marked as complete. 🔄️
ko guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
ko recipes/add-yaml-support.mdx Localization changed, will be marked as complete.
ko recipes/build-custom-img-component.mdx Localization changed, will be marked as complete.
ko recipes/build-forms-api.mdx Localization changed, will be marked as complete.
ko recipes/build-forms.mdx Localization changed, will be marked as complete.
ko recipes/call-endpoints.mdx Localization changed, will be marked as complete.
ko recipes/captcha.mdx Localization changed, will be marked as complete.
ko recipes/docker.mdx Localization changed, will be marked as complete. 🔄️
ko recipes/dynamically-importing-images.mdx Localization changed, will be marked as complete.
ko recipes/external-links.mdx Localization changed, will be marked as complete.
ko recipes/i18n.mdx Localization changed, will be marked as complete.
ko recipes/making-toolbar-apps.mdx Localization changed, will be marked as complete.
ko recipes/modified-time.mdx Localization changed, will be marked as complete.
ko recipes/reading-time.mdx Localization changed, will be marked as complete.
ko recipes/sharing-state.mdx Localization changed, will be marked as complete.
ko recipes/tailwind-rendered-markdown.mdx Localization changed, will be marked as complete.
ko reference/integrations-reference.mdx Localization changed, will be marked as complete.
ko reference/publish-to-npm.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@jsparkdev
Copy link
Contributor Author

thank you

All updates have been added.

@sarah11918
Copy link
Member

sarah11918 commented May 16, 2024

Reference pages reviewed for Steps/visual check! LGTM
Upgrade to pages reviewed for Steps/visual check! LGTM
Integrations guide pages reviewed for Steps/visual check! LGTM
Guides: E-commerce , server-side-rendering and RSS reviewed for Steps/visual check! LGTM

@HiDeoo
Copy link
Member

HiDeoo commented May 16, 2024

Deploy folder pages reviewed for Steps/visual check! LGTM

@HiDeoo
Copy link
Member

HiDeoo commented May 16, 2024

Migrate to Astro folder pages reviewed for Steps/visual check! LGTM
Markdown content / Middleware pages reviewed for Steps/visual check! LGTM

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All steps in CMS guides look correct 🎉

@HiDeoo
Copy link
Member

HiDeoo commented May 16, 2024

The testing page is missing a few steps added later in #8096

@sarah11918
Copy link
Member

The docker.mdx page has updated since this PR! You can find more changes here: #8226

@sarah11918
Copy link
Member

Thank you so much for all this work @jsparkdev ! On talking and doc'ing today, we all checked the deploy preview pages to make sure the Steps components looked right, but that's ALL we checked! We haven't checked these for being up to date with any new docs merges, but did point out if we noticed in particular.

So, following @yanthomasdev 's advice is still important! Otherwise, we've left comments as we checked for the Steps component only! 🙌

Copy link
Contributor

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/recipes is all 👍 and accurate, highlighting Sarah's comment wrt Docker

@jsparkdev
Copy link
Contributor Author

All updates have been completed. Thank you to everyone who reviewed.

In particular, #8226, which updates the docker.mdx file, is already reflected in the commit.

What part is wrong..?

@at-the-vr
Copy link
Contributor

Your right @jsparkdev, everything is aligned in both PRs 🥳 keeping it in tabs for further resolves. Safe to say - LGTM 👍

@jsparkdev
Copy link
Contributor Author

thank you!

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@yanthomasdev yanthomasdev merged commit be39d13 into withastro:main May 20, 2024
8 checks passed
@jsparkdev jsparkdev deleted the cms branch May 20, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants