fix(runtime): check head+content component before throwing an error #11141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3caee8a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
May 24, 2024
|
A test would be nice imo. With people using this a bunch for RSS, it's important that it works and stay working. |
Ok, let me see if I can pull it off |
|
I'm going to cc @delucis in here re: the docs question. It might not be worth changing the RSS docs just yet, unless this prevents the current method from working. |
ematipico
force-pushed
the
fix/runtime-check
branch
from
d8d4f73
to
3caee8a
Compare
Princesseuh
approved these changes
May 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue in our runtime engine. This fix allows the
AstroContainerto render theContainercomponent.Testing
I tested it manually against the source code that Chris created yesterday.
Docs
/cc @withastro/maintainers-docs for feedback!
We could potentially create a PR to update the RSS page and use the container to render the content collection.